Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker/doc): apply docker file with new release version #12200

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Sep 11, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After 1.2.0 is released, change docker compose file and README doc to apply this change.

Close #11781

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@hengm3467 hengm3467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcy-fdu wcy-fdu added this pull request to the merge queue Sep 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2023
@wcy-fdu wcy-fdu enabled auto-merge September 12, 2023 07:16
@wcy-fdu wcy-fdu added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 8b61c92 Sep 12, 2023
5 of 6 checks passed
@wcy-fdu wcy-fdu deleted the wcy/apply_docker_for_new_rw_version branch September 12, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove data_path in docker-compose-xxx.yml
2 participants