Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix openssl build error for nightly binary #12198

Closed
wants to merge 6 commits into from
Closed

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 11, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

ref https://stackoverflow.com/questions/70464585/error-when-installing-openssl-3-0-1-cant-locate-ipc-cmd-pm-in-inc

tested here https://buildkite.com/risingwavelabs/docker/builds/14222#018a8299-07e1-43cc-b961-1976e39ffd00

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Sep 11, 2023
@xxchan xxchan requested a review from huangjw806 September 11, 2023 04:59
@xxchan xxchan marked this pull request as ready for review September 11, 2023 04:59
@xxchan
Copy link
Member Author

xxchan commented Sep 11, 2023

oops
image

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #12198 (b9321d2) into main (d0a4984) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

❗ Current head b9321d2 differs from pull request most recent head ffc3963. Consider uploading reports for the commit ffc3963 to get more accurate results

@@            Coverage Diff             @@
##             main   #12198      +/-   ##
==========================================
- Coverage   69.79%   69.79%   -0.01%     
==========================================
  Files        1408     1408              
  Lines      235678   235678              
==========================================
- Hits       164503   164500       -3     
- Misses      71175    71178       +3     
Flag Coverage Δ
rust 69.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan xxchan self-assigned this Sep 11, 2023
@xxchan xxchan marked this pull request as draft September 11, 2023 07:34
@xxchan xxchan removed their assignment Sep 11, 2023
Copy link
Contributor

This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review.

@xxchan
Copy link
Member Author

xxchan commented Nov 30, 2023

retrying #13746 (actually got same result

@xxchan xxchan closed this Nov 30, 2023
@xxchan xxchan deleted the xxchan/o branch April 18, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant