Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): add build cache #12195

Closed
wants to merge 4 commits into from
Closed

build(docker): add build cache #12195

wants to merge 4 commits into from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 11, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

https://docs.docker.com/build/cache/backends/

close #7734

Tested here https://buildkite.com/risingwavelabs/docker/builds?branch=xxchan%2Fdocker-cache

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

xxchan added a commit that referenced this pull request Sep 11, 2023
Squashed commit of the following:

commit d90c234
Author: xxchan <[email protected]>
Date:   Mon Sep 11 11:08:33 2023 +0800

    --load

commit fb44d39
Author: xxchan <[email protected]>
Date:   Mon Sep 11 10:49:22 2023 +0800

    --progress plain

commit 4e8aae3
Author: xxchan <[email protected]>
Date:   Mon Sep 11 10:41:24 2023 +0800

    Use Docker container build driver

commit 10e04c4
Author: xxchan <[email protected]>
Date:   Mon Sep 11 10:37:39 2023 +0800

    build(docker): add build cache

    https://docs.docker.com/build/cache/backends/
@xxchan
Copy link
Member Author

xxchan commented Sep 11, 2023

contained in #12193

@xxchan xxchan closed this Sep 11, 2023
@xxchan xxchan deleted the xxchan/docker-cache branch November 3, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid being blocked by errors when building docker image
1 participant