Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ban pk comprising impure generated column #12181

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Sep 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #11741

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

The generated columns with impure expression should not be part of the defined primary key in a table.

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su yuhao-su requested a review from st1page September 8, 2023 09:28
@github-actions github-actions bot added the type/fix Bug fix label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #12181 (dd1601d) into main (e097adc) will decrease coverage by 0.01%.
Report is 7 commits behind head on main.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##             main   #12181      +/-   ##
==========================================
- Coverage   69.76%   69.76%   -0.01%     
==========================================
  Files        1407     1407              
  Lines      235569   235594      +25     
==========================================
+ Hits       164349   164364      +15     
- Misses      71220    71230      +10     
Flag Coverage Δ
rust 69.76% <85.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/frontend/src/handler/create_table.rs 84.57% <80.00%> (-0.16%) ⬇️
src/frontend/src/handler/create_source.rs 48.45% <100.00%> (+0.31%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@yuhao-su yuhao-su requested a review from BugenZhao September 11, 2023 06:31
@yuhao-su yuhao-su added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit b80e13f Sep 11, 2023
4 checks passed
@yuhao-su yuhao-su deleted the yuhao/ban_impure_gc_as_pk branch September 11, 2023 07:42
@yuhao-su yuhao-su changed the title fix: ban pk comprising generated column fix: ban pk comprising impure generated column Sep 11, 2023
Li0k pushed a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ban table's impure generated column as primary key
2 participants