fix: protobuf fixed64 was incorrectly parsed as int64 #12126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12126 +/- ##
==========================================
+ Coverage 69.77% 69.82% +0.04%
==========================================
Files 1406 1406
Lines 235333 235518 +185
==========================================
+ Hits 164203 164445 +242
+ Misses 71130 71073 -57
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TennyZhuang
approved these changes
Sep 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
neverchanje
added a commit
that referenced
this pull request
Sep 8, 2023
lmatz
pushed a commit
that referenced
this pull request
Sep 8, 2023
Li0k
pushed a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Protobuf's fixed64 was mapped to RisingWave's int64 (bigint) during create source.
However, prost treats fixed64 as uint64 and then we actually turned uint64 into decimals during parsing. As a result, there was a mismatch between the actual array's type (bigint) and the value's type (decimal).
This PR fixes this bug and map fixed64 to decimal instead.
Additionally, this PR rejects the
maptype in Protobuf. Because we don't yet have a correct handling path. Previously, we convert map toLIST<STRUCT<key VARCHAR, value INT32>>, which is unexpected.related issue: #10479
Checklist
./risedev check(or alias,./risedev c)Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.