Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sink): (early preview) support both json and proto encoding #12125

Closed
wants to merge 12 commits into from

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Sep 6, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

related: #11995

preview 1 (933072a)

  • RowEncoder
  • SinkFormatter
  • MessageSink

TODOs:

  • RowEncoder generalize of serde_json::Value::null on upsert op::delete
    • The new behavior is correct (empty value) while the existing is wrong (4 byte null). It is for kafka log compaction.
  • SinkFormatter support multiple output on debezium_json op::delete
  • impl SerToString for String clones unnecessarily
  • forbid UpsertFormatter with EmptyEncoder as key
  • MessageSink for nats and redis

preview 0 (c5f87ad)

As an example, only touched {kinesis,kafka} x append-only.

  • impl RecordEncoder for JsonEncoder and ProtoEncoder(MessageDescriptor)
  • impl ToBytes for Map<String, serde_json::Value> and DynamicMessage
  • pk_to_json and record_to_json has been superseded by
encode_row<'a, E: RecordEncoder>(
    encoder: &E,
    row: RowRef<'_>,
    schema: &[Field],
    extra: impl Into<ExtraParam<'a>>,
) -> Result<E::Output>
  • The async stream gen_append_only_message_stream has been replaced by a sync Iterator-like GenAppendOnlyMsg.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xiangjinwu xiangjinwu force-pushed the feat-sink-kafka-protobuf-0-StreamMap branch from c5f87ad to 547f5a8 Compare September 8, 2023 12:10
@xiangjinwu
Copy link
Contributor Author

xiangjinwu commented Sep 15, 2023

Being split into several parts:

RowEncoder #12264
├───────────────────────┬──────────────────────┐
SinkFormatter #12321    ProtoEncoder #?????    AvroEncoder #?????
├───────────────────────────────┐
DebeziumJsonFormatter #12372    NatsFormattedSink #?????

@xiangjinwu xiangjinwu closed this Sep 15, 2023
@xiangjinwu xiangjinwu deleted the feat-sink-kafka-protobuf-0-StreamMap branch September 18, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant