refactor(storage): Use TableKey struct in the state store interfaces #11943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcy-fdu
reviewed
Aug 30, 2023
| @@ -46,15 +51,19 @@ pub enum KeyOp { | |||
| /// `MemTable` is a buffer for modify operations without encoding | |||
| #[derive(Clone)] | |||
| pub struct MemTable { | |||
| pub(crate) buffer: BTreeMap<Bytes, KeyOp>, | |||
| pub(crate) buffer: BTreeMap<TableKey<Bytes>, KeyOp>, | |||
There was a problem hiding this comment.
Do we need #[derive(EstimateSize)] for TableKey to make memory statistics more accurate?
There was a problem hiding this comment.
It is already done in this PR here.
hzxa21
force-pushed
the
patrick/memtable-table-key.pr
branch
4 times, most recently
from
48d7d08 to
bd980c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #11943 +/- ##
==========================================
- Coverage 69.73% 69.71% -0.02%
==========================================
Files 1424 1422 -2
Lines 236446 236103 -343
==========================================
- Hits 164881 164601 -280
+ Misses 71565 71502 -63
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wenym1
approved these changes
Sep 15, 2023
hzxa21
force-pushed
the
patrick/memtable-table-key.pr
branch
from
ba2e73d to
94c59b8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hzxa21
force-pushed
the
patrick/memtable-table-key.pr
branch
from
94c59b8 to
d6a0d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #11927
HummockStorageinto src/storage/hummock/store/hummock_storage.rsLocalHummockStorageinto src/storage/hummock/store/local_hummock_storage.rsChecklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.