-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support show and cancel jobs syntax #11854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 3979 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1753 | 1 | 2225 | 0 |
Click to see the invalid file list
- src/frontend/src/handler/cancel_job.rs
Codecov Report
@@ Coverage Diff @@
## main #11854 +/- ##
==========================================
- Coverage 70.22% 70.18% -0.04%
==========================================
Files 1373 1374 +1
Lines 228708 228818 +110
==========================================
- Hits 160608 160599 -9
- Misses 68100 68219 +119
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
I am wondering if you have got the wrong idea what a job is in cockroachdb. A job specifically refers to a "system maintanence task" https://www.cockroachlabs.com/docs/stable/ui-jobs-page. The correct syntax that we can follow is https://www.cockroachlabs.com/docs/stable/cancel-query CANCEL QUERY. We'll need My concern is that users will have to understand one more concept if you use JOB to indicate a query or statement. I also found that this requirement is common and most systems prefer to implement a non-standard syntax for it.
|
@neverchanje suggested that not to introduce a new job concept but to cancel creating streaming jobs with existed command like |
What about simply calling it |
Well I think it's much more like |
I personally suggest:
Well, the |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #8032 , support syntax to show and cancel creating streaming jobs:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
support syntax to show and cancel creating streaming jobs.