-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compaction): decouple compactor struct with compactor context #11832
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11832 +/- ##
==========================================
- Coverage 70.20% 70.20% -0.01%
==========================================
Files 1373 1373
Lines 228576 228618 +42
==========================================
+ Hits 160472 160492 +20
- Misses 68104 68126 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, the goal is to separate task-level parameters and process-level parameters. However, I don't see how this PR can help since we still have CompactorContext storing all the parameters. This PR is somehow preliminary and just modifies severl method to accept handcrafted parameters instead of CompactorContext. I suggest we work on a PR for parameter separation as a whole.
let compactor_metrics_cloned = self.compactor_metrics.clone(); | ||
let is_share_buffer_compact = self.is_share_buffer_compact; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems redundant to clone the metric and define two variables here.
Close as #12020 is more reasonable |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.