Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump toolchain to 2023-09-09 #11809

Merged
merged 33 commits into from
Sep 9, 2023
Merged

build: bump toolchain to 2023-09-09 #11809

merged 33 commits into from
Sep 9, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Aug 21, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan mentioned this pull request Aug 21, 2023
8 tasks
@xxchan xxchan changed the title bump toolchain build: bump toolchain to 2023-08-21 Aug 21, 2023
xxchan and others added 8 commits August 21, 2023 17:22
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx
Copy link
Contributor

MrCroxx commented Aug 28, 2023

There are some problems to notice in this PR:

  1. Impl of Ord and PartialOrd

In the old codes, PartialOrd is sometimes implemented before Ord incorrectly.

e.g. https://github.com/risingwavelabs/risingwave/blob/main/src/common/src/array/list_array.rs#L325-L335

impl PartialOrd for ListValue {
    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
        self.as_scalar_ref().partial_cmp(&other.as_scalar_ref())
    }
}

impl Ord for ListValue {
    fn cmp(&self, other: &Self) -> Ordering {
        self.partial_cmp(other).unwrap()
    }
}

In Rust, if a struct implements total order with Ord, its partial order implementation in PartialOrd must agree with its total order. Refs: https://doc.rust-lang.org/std/cmp/trait.Ord.html

So, the new version of clippy will check if the implementation of PartialOrd is Some(self.cmp(other)) or Some(std::cmp(self, other)) to ensure the two implementation equals.

  1. clippy bug

See rust-lang/rust-clippy#11380

I left comments in this PR and temporarily allowed the rule.

@MrCroxx MrCroxx requested a review from TennyZhuang August 28, 2023 17:08
@MrCroxx MrCroxx marked this pull request as ready for review August 28, 2023 17:08
@MrCroxx MrCroxx requested review from BugenZhao and st1page August 29, 2023 01:40
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
src/meta/src/stream/stream_graph/schedule.rs Show resolved Hide resolved
src/storage/src/hummock/utils.rs Outdated Show resolved Hide resolved
src/storage/src/monitor/monitored_store.rs Outdated Show resolved Hide resolved
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@xxchan xxchan requested a review from a team as a code owner September 9, 2023 07:11
@xxchan xxchan enabled auto-merge September 9, 2023 07:36
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@xxchan xxchan changed the title build: bump toolchain to 2023-08-21 build: bump toolchain to 2023-09-09 Sep 9, 2023
@xxchan xxchan added this pull request to the merge queue Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #11809 (69f2e71) into main (6806eca) will increase coverage by 0.00%.
The diff coverage is 64.77%.

@@           Coverage Diff           @@
##             main   #11809   +/-   ##
=======================================
  Coverage   69.80%   69.80%           
=======================================
  Files        1408     1408           
  Lines      235759   235667   -92     
=======================================
- Hits       164581   164519   -62     
+ Misses      71178    71148   -30     
Flag Coverage Δ
rust 69.80% <64.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/batch/src/executor/sort_over_window.rs 0.00% <ø> (ø)
src/batch/src/executor/source.rs 0.00% <0.00%> (ø)
src/batch/src/task/task_manager.rs 72.03% <0.00%> (ø)
src/common/common_service/src/tracing.rs 0.00% <0.00%> (ø)
src/common/src/array/stream_chunk.rs 61.71% <ø> (ø)
src/common/src/types/ordered.rs 80.95% <ø> (ø)
src/compute/src/memory_management/policy.rs 0.00% <0.00%> (ø)
src/compute/src/rpc/service/exchange_service.rs 0.00% <ø> (ø)
src/compute/src/rpc/service/monitor_service.rs 0.00% <0.00%> (ø)
src/connector/src/parser/util.rs 3.22% <ø> (ø)
... and 157 more

... and 103 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit f649aa6 Sep 9, 2023
@xxchan xxchan deleted the tygg-bump-toolchain-20230728 branch September 9, 2023 15:14
stdrc pushed a commit that referenced this pull request Sep 12, 2023
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Co-authored-by: TennyZhuang <zty0826@gmail.com>
Co-authored-by: MrCroxx <mrcroxx@outlook.com>
Co-authored-by: William Wen <william123.wen@gmail.com>
Co-authored-by: xxchan <xxchan@users.noreply.github.com>
Li0k pushed a commit that referenced this pull request Sep 15, 2023
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Co-authored-by: TennyZhuang <zty0826@gmail.com>
Co-authored-by: MrCroxx <mrcroxx@outlook.com>
Co-authored-by: William Wen <william123.wen@gmail.com>
Co-authored-by: xxchan <xxchan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants