-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump toolchain to 2023-09-09 #11809
Conversation
Signed-off-by: TennyZhuang <zty0826@gmail.com>
rust-lang/rust#114727 Also - Update to nightly's new Error::provide API - Fix some lints
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
There are some problems to notice in this PR:
In the old codes, e.g. https://github.com/risingwavelabs/risingwave/blob/main/src/common/src/array/list_array.rs#L325-L335 impl PartialOrd for ListValue {
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
self.as_scalar_ref().partial_cmp(&other.as_scalar_ref())
}
}
impl Ord for ListValue {
fn cmp(&self, other: &Self) -> Ordering {
self.partial_cmp(other).unwrap()
}
} In Rust, if a struct implements total order with So, the new version of clippy will check if the implementation of
See rust-lang/rust-clippy#11380 I left comments in this PR and temporarily allowed the rule. |
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
Codecov Report
@@ Coverage Diff @@
## main #11809 +/- ##
=======================================
Coverage 69.80% 69.80%
=======================================
Files 1408 1408
Lines 235759 235667 -92
=======================================
- Hits 164581 164519 -62
+ Misses 71178 71148 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 103 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: TennyZhuang <zty0826@gmail.com> Signed-off-by: MrCroxx <mrcroxx@outlook.com> Co-authored-by: TennyZhuang <zty0826@gmail.com> Co-authored-by: MrCroxx <mrcroxx@outlook.com> Co-authored-by: William Wen <william123.wen@gmail.com> Co-authored-by: xxchan <xxchan@users.noreply.github.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com> Signed-off-by: MrCroxx <mrcroxx@outlook.com> Co-authored-by: TennyZhuang <zty0826@gmail.com> Co-authored-by: MrCroxx <mrcroxx@outlook.com> Co-authored-by: William Wen <william123.wen@gmail.com> Co-authored-by: xxchan <xxchan@users.noreply.github.com>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.