build: bump toolchain to 2023-09-09

[xxchan]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[MrCroxx]

There are some problems to notice in this PR:

1. Impl of Ord and PartialOrd

In the old codes, PartialOrd is sometimes implemented before Ord incorrectly.

e.g. https://github.com/risingwavelabs/risingwave/blob/main/src/common/src/array/list_array.rs#L325-L335

impl PartialOrd for ListValue {
    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
        self.as_scalar_ref().partial_cmp(&other.as_scalar_ref())
    }
}

impl Ord for ListValue {
    fn cmp(&self, other: &Self) -> Ordering {
        self.partial_cmp(other).unwrap()
    }
}

In Rust, if a struct implements total order with Ord, its partial order implementation in PartialOrd must agree with its total order. Refs: https://doc.rust-lang.org/std/cmp/trait.Ord.html

So, the new version of clippy will check if the implementation of PartialOrd is Some(self.cmp(other)) or Some(std::cmp(self, other)) to ensure the two implementation equals.

2. clippy bug

See rust-lang/rust-clippy#11380

I left comments in this PR and temporarily allowed the rule.

[fuyufjh]

Thanks for the work!

[codecov]

Codecov Report

Merging #11809 (69f2e71) into main (6806eca) will increase coverage by 0.00%.
The diff coverage is 64.77%.

@@           Coverage Diff           @@
##             main   #11809   +/-   ##
=======================================
  Coverage   69.80%   69.80%           
=======================================
  Files        1408     1408           
  Lines      235759   235667   -92     
=======================================
- Hits       164581   164519   -62     
+ Misses      71178    71148   -30     

Flag	Coverage Δ
rust	69.80% <64.77%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/batch/src/executor/sort_over_window.rs	0.00% <ø> (ø)
src/batch/src/executor/source.rs	0.00% <0.00%> (ø)
src/batch/src/task/task_manager.rs	72.03% <0.00%> (ø)
src/common/common_service/src/tracing.rs	0.00% <0.00%> (ø)
src/common/src/array/stream_chunk.rs	61.71% <ø> (ø)
src/common/src/types/ordered.rs	80.95% <ø> (ø)
src/compute/src/memory_management/policy.rs	0.00% <0.00%> (ø)
src/compute/src/rpc/service/exchange_service.rs	0.00% <ø> (ø)
src/compute/src/rpc/service/monitor_service.rs	0.00% <0.00%> (ø)
src/connector/src/parser/util.rs	3.22% <ø> (ø)
... and 157 more

... and 103 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more