Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqlparser): support array constructing subquery syntax array(select 2) #11716

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Related: #11202

Syntactically similar to exists subquery. Note this is only to parse it into AST, so that we can detect it at AST level rather than string level. It may also be implemented by rewriting into array_agg later.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #11716 (775df29) into main (c1a4e01) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main   #11716      +/-   ##
==========================================
- Coverage   70.37%   70.35%   -0.03%     
==========================================
  Files        1365     1365              
  Lines      228176   228185       +9     
==========================================
- Hits       160584   160543      -41     
- Misses      67592    67642      +50     
Flag Coverage Δ
rust 70.35% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/meta/src/manager/catalog/utils.rs 49.13% <0.00%> (-0.18%) ⬇️
src/sqlparser/src/ast/mod.rs 84.82% <100.00%> (+0.01%) ⬆️
src/sqlparser/src/parser.rs 86.41% <100.00%> (+0.03%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 913a1d4 Aug 16, 2023
@xiangjinwu xiangjinwu deleted the feat-sqlparser-subquery-array branch August 16, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants