-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka source&sink): expose rdkafka fetch params #11203
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11203 +/- ##
==========================================
- Coverage 69.74% 69.73% -0.02%
==========================================
Files 1313 1313
Lines 224257 224410 +153
==========================================
+ Hits 156414 156496 +82
- Misses 67843 67914 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Depends on #11232 because Update: I have removed |
c396ed9
to
27aba9e
Compare
27aba9e
to
42645de
Compare
@tabVersion LGTM. You may give an approval by yourself 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Expose these configurations for the convenience of debugging in the future.
I'll set better parameters in a separate PR, after sufficient performance test, etc.
related #10888 #11229
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
allow user specify kafka params in rw SQL (description in details available here)
valid for both source and sink
properties.message.max.bytes
message.max.bytes
properties.receive.message.max.bytes
receive.message.max.bytes
only valid in source
properties.queued.min.messages
queued.min.messages
properties.queued.max.messages.kbytes
queued.max.messages.kbytes
properties.fetch.wait.max.ms
fetch.wait.max.ms
properties.fetch.max.bytes
fetch.max.bytes
only valid for sink
properties.queue.buffering.max.messages
queue.buffering.max.messages
properties.queue.buffering.max.kbytes
queue.buffering.max.kbytes
properties.queue.buffering.max.ms
queue.buffering.max.ms
properties.enable.idempotence
enable.idempotence
'true'
and'false'
)properties.message.send.max.retries
message.send.max.retries
properties.retry.backoff.ms
retry.backoff.ms
properties.batch.num.messages
batch.num.messages
properties.batch.size
batch.size