refactor(test): move hash agg executor tests to integration_tests
#10113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #10113 +/- ##
==========================================
- Coverage 71.00% 70.94% -0.07%
==========================================
Files 1233 1233
Lines 211386 210898 -488
==========================================
- Hits 150092 149612 -480
+ Misses 61294 61286 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xxchan
approved these changes
Jun 1, 2023
| echo "Tip: use the alias $(tput setaf 4)./risedev usit$(tput sgr0)." | ||
| ''' | ||
|
|
||
| [tasks.usit] |
There was a problem hiding this comment.
What about dasit or dast? similar to dapt
There was a problem hiding this comment.
do-apply-stream-integration-test?
| test_local_hash_aggregation_min_append_only(MemoryStateStore::new()).await | ||
| } | ||
|
|
||
| async fn test_local_hash_aggregation_count<S: StateStore>(store: S) { |
There was a problem hiding this comment.
This test is deleted. Is that intended?
There was a problem hiding this comment.
Yes, this test looks the same as another so called global one.
Signed-off-by: Richard Chien <[email protected]>
kwannoel
pushed a commit
that referenced
this pull request
Jun 6, 2023
…10113) Signed-off-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR also adds
SnapshotOptionsto resolve #10005, andrisedev update-stream-integration-testsubcommand for convenience (mentioned in #9787 (comment)).Checklist For Contributors
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note