Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test client libraries in the main-cron test #9958

Closed
6 tasks done
lmatz opened this issue May 23, 2023 · 3 comments
Closed
6 tasks done

test client libraries in the main-cron test #9958

lmatz opened this issue May 23, 2023 · 3 comments
Assignees

Comments

@lmatz
Copy link
Contributor

lmatz commented May 23, 2023

https://www.notion.so/risingwave-labs/client-libraries-215dccb91503473787a4ddfe0aa2b422

Please write the tests and run them in the main-cron test so that we can verify them on a daily basis.

Feel free to assign the owner to each test. @sumittal

Please open a PR once the implementation of tests starts so that people can help.

@github-actions github-actions bot added this to the release-0.20 milestone May 23, 2023
@xxchan
Copy link
Member

xxchan commented May 23, 2023

BTW, here's a prior art: #7113

Basically sqllogictest --engine=external can create a subprocess as the driver (with this protocol https://github.com/risinglightdb/sqllogictest-rs/blob/27eb9f50993e10b36c1f4f68ad3afe499adbbb49/sqllogictest-engines/src/external.rs#L16-L36), so we can test any client library with all our slt test suites in this way. Although I'm not sure whether we want to do so, or just some simple tests are enough.

@github-actions
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@lmatz
Copy link
Contributor Author

lmatz commented Jul 24, 2023

Basically sqllogictest --engine=external can create a subprocess as the driver (with this protocol https://github.com/risinglightdb/sqllogictest-rs/blob/27eb9f50993e10b36c1f4f68ad3afe499adbbb49/sqllogictest-engines/src/external.rs#L16-L36), so we can test any client library with all our slt test suites in this way. Although I'm not sure whether we want to do so, or just some simple tests are enough.

cc: @abhyuday26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants