-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: extended query mode / 3rd-party tools are not well tested #14141
Comments
Would simulation test help? I once created an issue #5552 but thought it was low priority. |
I believe we should first make |
Opened an issue in |
@xuefengze Can you take a look? Perhaps query with different (go/java/...) clients can also solve this. May need more discussion. |
This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned. |
Duplicated #8213 |
Recently there was a regression (#14102) for not being able to connect RisingWave with 3rd-party tools, which primarily relies on the extended query mode. Despite the timely release of the quick fix in v1.5.2, we still didn't conduct any testing on it. As a result, it could be easily broken again in the future (#14105 (review)).
As shown in
e2e_test/extended_mode
, very limited cases are tested with extended mode.risingwave/e2e_test/extended_mode/type.slt
Lines 21 to 28 in d5a8184
I would suggest adding more tests for extended mode query by focusing on the real cases. Possible approaches:
sqllogictest
case.However, it's worth noting that
sqllogictest-rs
does not have full support on postgres extended mode: onlyprepare
andquery
is covered. Improvements need to be made to supportparse
,bind
,execute
,describe
and so on.The text was updated successfully, but these errors were encountered: