Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extended query mode / 3rd-party tools are not well tested #14141

Closed
BugenZhao opened this issue Dec 22, 2023 · 8 comments
Closed

test: extended query mode / 3rd-party tools are not well tested #14141

BugenZhao opened this issue Dec 22, 2023 · 8 comments
Labels
component/frontend Protocol, parsing, binder. component/test Test related issue. no-issue-activity type/enhancement Improvements to existing implementation.
Milestone

Comments

@BugenZhao
Copy link
Member

Recently there was a regression (#14102) for not being able to connect RisingWave with 3rd-party tools, which primarily relies on the extended query mode. Despite the timely release of the quick fix in v1.5.2, we still didn't conduct any testing on it. As a result, it could be easily broken again in the future (#14105 (review)).

As shown in e2e_test/extended_mode, very limited cases are tested with extended mode.

include ../batch/types/boolean.slt.part
include ../batch/types/cast.slt.part
include ../batch/types/date.slt
include ../batch/types/intercal.slt.part
include ../batch/types/number_arithmetic.slt.part
include ../batch/types/temporal_arithmetic.slt.part
include ../batch/types/time.slt.part
include ../batch/types/timestamptz_utc.slt.part

I would suggest adding more tests for extended mode query by focusing on the real cases. Possible approaches:

  • Integrate 3rd-party tools in CI and emulate some basic operations. For GUI tools, use GUI automation.
  • Manually emulate basic operations with 3rd-party tools, then dump the queries into a sqllogictest case.
    However, it's worth noting that sqllogictest-rs does not have full support on postgres extended mode: only prepare and query is covered. Improvements need to be made to support parse, bind, execute, describe and so on.
@github-actions github-actions bot added this to the release-1.6 milestone Dec 22, 2023
@BugenZhao BugenZhao added component/test Test related issue. component/frontend Protocol, parsing, binder. type/enhancement Improvements to existing implementation. labels Dec 22, 2023
@xxchan
Copy link
Member

xxchan commented Dec 22, 2023

#9958

@TennyZhuang
Copy link
Contributor

#14116

@wangrunji0408
Copy link
Contributor

Would simulation test help? I once created an issue #5552 but thought it was low priority.

@BugenZhao
Copy link
Member Author

Would simulation test help? I once created an issue #5552 but thought it was low priority.

I believe we should first make sqllogictest-rs support more extended-mode messages. Alternatively, we can bypass using slt as the intermediate representation and program directly in simulation tests.

@BugenZhao
Copy link
Member Author

Opened an issue in sqllogictest-rs: risinglightdb/sqllogictest-rs#205

@fuyufjh
Copy link
Member

fuyufjh commented Jan 9, 2024

@xuefengze Can you take a look? Perhaps query with different (go/java/...) clients can also solve this. May need more discussion.

@xuefengze xuefengze modified the milestones: release-1.6, release-1.8 Mar 6, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@fuyufjh
Copy link
Member

fuyufjh commented Oct 17, 2024

Duplicated #8213

@fuyufjh fuyufjh closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/frontend Protocol, parsing, binder. component/test Test related issue. no-issue-activity type/enhancement Improvements to existing implementation.
Projects
None yet
Development

No branches or pull requests

6 participants