Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaurantee the order of writes when writes come from the same session #7134

Closed
lmatz opened this issue Dec 29, 2022 · 4 comments
Closed

gaurantee the order of writes when writes come from the same session #7134

lmatz opened this issue Dec 29, 2022 · 4 comments
Labels
no-issue-activity type/bug Something isn't working

Comments

@lmatz
Copy link
Contributor

lmatz commented Dec 29, 2022

Due to https://github.com/risingwavelabs/risingwave/blob/main/src/source/src/table.rs#L86,
we may not know which writes will win when there are multiple ones.
(pk conflict, and due to https://github.com/risingwavelabs/rfcs/pull/4/files#diff-73ca4924ee3c22e62b50a34acb513c5252bc3d5c44075d5b0398a2387f6d5c4dR32, the first writes win and the rest will be ignored)?

from the same session seems to be a reasonable setting

@github-actions github-actions bot added this to the release-0.1.16 milestone Dec 29, 2022
@BugenZhao
Copy link
Member

A quick but working workaround might be always scheduling the DML to a fixed node and choosing a fixed parallelism here. 🥵

@lmatz
Copy link
Contributor Author

lmatz commented Dec 30, 2022

A quick but working workaround might be always scheduling the DML to a fixed node and choosing a fixed parallelism here. 🥵

https://github.com/risingwavelabs/rfcs/pull/4/files#diff-73ca4924ee3c22e62b50a34acb513c5252bc3d5c44075d5b0398a2387f6d5c4dR54 seems there was a plan

@fuyufjh fuyufjh removed this from the release-0.1.16 milestone Jan 30, 2023
@fuyufjh fuyufjh added the type/bug Something isn't working label Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@xxchan
Copy link
Member

xxchan commented Apr 6, 2023

close in favor of #7213

@xxchan xxchan closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants