Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expr): regex operator ~ / !~ should return null when either input is null #5136

Closed
yezizp2012 opened this issue Sep 6, 2022 · 1 comment · Fixed by #13145
Closed

fix(expr): regex operator ~ / !~ should return null when either input is null #5136

yezizp2012 opened this issue Sep 6, 2022 · 1 comment · Fixed by #13145
Assignees
@xiangjinwu
Labels
type/bug Something isn't working
Milestone
release-1.4

Comments

@yezizp2012
Copy link
Member

This rewrite is not equivalent when either left or right is null. The operator returns null but this returns false. Let's open an issue to track the fix.

Originally posted by @xiangjinwu in #5127 (comment)
@github-actions github-actions bot added this to the release-0.1.13 milestone Sep 6, 2022
@yezizp2012 yezizp2012 changed the title fix regex (un)match binary operation bind with null left/right fix(frontend): fix regex (un)match binary operation bind with null left/right Sep 6, 2022
@xiangjinwu xiangjinwu self-assigned this Sep 7, 2022
@lmatz lmatz added the type/bug Something isn't working label Nov 23, 2022
@xiangjinwu xiangjinwu mentioned this issue Dec 7, 2022
Merged
3 tasks
@xiangjinwu xiangjinwu modified the milestones: release-0.18, release-0.19 Mar 20, 2023
@xiangjinwu xiangjinwu mentioned this issue Mar 29, 2023
Open
50 tasks
@xiangjinwu xiangjinwu changed the title fix(frontend): fix regex (un)match binary operation bind with null left/right fix(expr): regex operator ~ / !~ should return null when either input is null Apr 4, 2023
@xiangjinwu xiangjinwu modified the milestones: release-0.19, release-0.20 Apr 26, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.0, release-1.1 Jul 14, 2023
@xiangjinwu
Copy link
Contributor

This can be supported by forking the regex_match backend implementation, which may soon be replaced by an enhanced prebuilt attribute of the expression macro (see regex_matches in #9949). So deferring this until that is available.

Also note some other incompatibilities with PostgreSQL: #7136

@xiangjinwu xiangjinwu removed this from the release-1.1 milestone Jul 17, 2023
@xiangjinwu xiangjinwu added this to the future-release-1.3 milestone Aug 24, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.3, release-1.4 Oct 10, 2023
@xiangjinwu xiangjinwu mentioned this issue Oct 30, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangjinwu xiangjinwu

Labels
type/bug Something isn't working
Projects
None yet
Milestone
release-1.4
Development

Successfully merging a pull request may close this issue.

fix(expr): null input of ~ / !~ risingwavelabs/risingwave
3 participants
@lmatz @yezizp2012 @xiangjinwu