Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(sink): panic on "should not receive any data after pause" #19117

Closed
zwang28 opened this issue Oct 24, 2024 · 2 comments · Fixed by #19199
Closed

bug(sink): panic on "should not receive any data after pause" #19117

zwang28 opened this issue Oct 24, 2024 · 2 comments · Fixed by #19199
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@zwang28
Copy link
Contributor

zwang28 commented Oct 24, 2024

Describe the bug

The only compute node panicked on panicked at src/stream/src/executor/sink.rs:277:21:\nShould not receive any data after pause.

There're sinks in the cluster. The user was creating multiple sink into table at the time.

https://risingwave-labs.slack.com/archives/C034TRPKN1F/p1730175390802129

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

v2.0.2

Additional context

No response

@zwang28 zwang28 added the type/bug Something isn't working label Oct 24, 2024
@github-actions github-actions bot added this to the release-2.2 milestone Oct 24, 2024
@zwang28

This comment was marked as outdated.

@zwang28 zwang28 assigned wenym1 and unassigned wenym1 Oct 28, 2024
@zwang28
Copy link
Contributor Author

zwang28 commented Oct 28, 2024

I believe the root cause is hash agg can emit data chunk on window close on receiving a barrier, even when the stream graph is already paused. I've confirmed that the cluster experiencing the panic includes a hash aggregation with an emit on window close.
e.g. [pause, configchange, resume]

Would you PTAL at accommodating hash agg emit to pause/resume barrier? Thanks. @stdrc

@BugenZhao BugenZhao changed the title bug(sink): panic on should not receive any data after pause bug(sink): panic on "should not receive any data after pause" Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment