Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get default column definition in auto schema mapping #18359

Closed
StrikeW opened this issue Sep 2, 2024 · 0 comments · Fixed by #18571
Closed

Get default column definition in auto schema mapping #18359

StrikeW opened this issue Sep 2, 2024 · 0 comments · Fixed by #18571
Assignees
Milestone

Comments

@StrikeW
Copy link
Contributor

StrikeW commented Sep 2, 2024

          > > And when create a new table, we won't capture the default value definition from upstream

Would this be somehow inconsistent and surprising to users? Note that default values are also used when performing DML.

For the case of auto schema mapping (create table t (*)), we can improve the feature in future to get the default value from upstream.
For the table with column definitions manually specified by user, I think they should also specify the default column by hand in the DDL.

Originally posted by @StrikeW in #18322 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant