Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a fast docker build buildkite workflow #18097

Closed
Tracked by #18058
kwannoel opened this issue Aug 19, 2024 · 2 comments · Fixed by #18124
Closed
Tracked by #18058

Add a fast docker build buildkite workflow #18097

kwannoel opened this issue Aug 19, 2024 · 2 comments · Fixed by #18124
Assignees
@huangjw806 @kwannoel
Milestone
release-2.1

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Aug 19, 2024 •
edited
Loading

Shared by @st1page previously.

  • @huangjw806 provision a dedicated stack for arm image.
  • @kwannoel add a dedicated pipeline which does not use LTO.
@kwannoel kwannoel mentioned this issue Aug 19, 2024
Open
2 tasks
@github-actions github-actions bot added this to the release-2.1 milestone Aug 19, 2024
@kwannoel kwannoel changed the title From @st1page: Speed up docker build. This is often the bottleneck in getting a patch deployed. Currently it runs around 30mins. Add a fast docker build buildkite workflow Aug 19, 2024
@huangjw806
Copy link
Contributor

Using c7g.8xlarge instance can shorten the arm docker build to less than 25 minutes
https://buildkite.com/risingwavelabs/docker/builds/16276

@kwannoel
Copy link
Contributor Author

kwannoel commented Aug 20, 2024 •
edited
Loading

Without lto it takes 16m40s.

I think with these 2 optimizations, we can bring it down to 10m.

Let's give it a shot.

https://buildkite.com/risingwavelabs/fast-docker-build-arm/builds/6#_

@kwannoel kwannoel mentioned this issue Aug 20, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huangjw806 huangjw806

@kwannoel kwannoel

Labels
None yet
Projects
None yet
Milestone
release-2.1
Development

Successfully merging a pull request may close this issue.

feat(ci): add fast-docker-build-arm workflow risingwavelabs/risingwave
2 participants
@huangjw806 @kwannoel