Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add streaming read retry for fast compaction #17962

Closed
hzxa21 opened this issue Aug 7, 2024 · 2 comments · Fixed by #18350
Closed

add streaming read retry for fast compaction #17962

hzxa21 opened this issue Aug 7, 2024 · 2 comments · Fixed by #18350
Assignees
Milestone

Comments

@hzxa21
Copy link
Collaborator

hzxa21 commented Aug 7, 2024

Is your feature request related to a problem? Please describe.

Currently fast compaction will not try to recreate the read stream like normal compaction based on compactor_iter_max_io_retry_times

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@Li0k
Copy link
Contributor

Li0k commented Sep 3, 2024

Before implementing stream reconstruction at the object store level, I added stream reconstruction as a workaround fix to the fast compactor iterator.

@Li0k
Copy link
Contributor

Li0k commented Sep 3, 2024

We can use a separate issue to track the changes to the object store behaviour and refactor the iterator-related code, but for now we can close the issue.

@Li0k Li0k closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants