Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support function timezone(zone, timestamp) #17363

Closed
lmatz opened this issue Jun 20, 2024 · 3 comments · Fixed by #19524
Closed

support function timezone(zone, timestamp) #17363

lmatz opened this issue Jun 20, 2024 · 3 comments · Fixed by #19524
Assignees
Labels
difficulty/simple Issues that relatively easy and friendly to newcomers. good first issue Good for newcomers priority/low type/feature

Comments

@lmatz
Copy link
Contributor

lmatz commented Jun 20, 2024

Is your feature request related to a problem? Please describe.

The function timezone(zone, timestamp) is equivalent to the SQL-conforming construct timestamp AT TIME ZONE zone.
https://www.postgresql.org/docs/current/functions-datetime.html#FUNCTIONS-DATETIME-ZONECONVERT
We have the latter

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@github-actions github-actions bot added this to the release-1.10 milestone Jun 20, 2024
@lmatz lmatz added priority/low good first issue Good for newcomers difficulty/simple Issues that relatively easy and friendly to newcomers. labels Jun 20, 2024
@lmatz lmatz removed this from the release-1.10 milestone Jul 10, 2024
@dttung2905
Copy link

Hi @lmatz, im new to this but interested in the issue. Do you have any pointers where to start?

@lmatz
Copy link
Contributor Author

lmatz commented Sep 11, 2024

Hi @dttung2905

Appreciate your interest in contributing to RW!
https://github.com/risingwavelabs/risingwave/blob/main/src/expr/impl/src/scalar/extract.rs is a time-related function, you can mimic the way how it is integrated into the codebase.

Feel free to assign the issue to yourself! Thanks

@dttung2905
Copy link

@lmatz thank you for the pointer. I will take a look at it today. You can assign it to me 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/simple Issues that relatively easy and friendly to newcomers. good first issue Good for newcomers priority/low type/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants