Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue operation in delete_objects function when errors occur #15651

Closed
NiuBlibing opened this issue Mar 13, 2024 · 0 comments · Fixed by #15704
Closed

Continue operation in delete_objects function when errors occur #15651

NiuBlibing opened this issue Mar 13, 2024 · 0 comments · Fixed by #15704
Milestone

Comments

@NiuBlibing
Copy link
Contributor

https://github.com/risingwavelabs/risingwave/blob/a37d53830789f32b0aa2b9ea6601850b20445969/src/object_store/src/object/s3.rs#L516C1-L518C14

Currently, in the delete_objects function, if any errors occur during the deletion process, the function immediately returns with an internal error, halting the operation. However, it might be more desirable to continue the operation and handle errors gracefully while processing the remaining objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant