Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backfill metrics should be dropped after backill finishes #15174

Closed
Tracked by #14838
hzxa21 opened this issue Feb 21, 2024 · 0 comments · Fixed by #15741
Closed
Tracked by #14838

backfill metrics should be dropped after backill finishes #15174

hzxa21 opened this issue Feb 21, 2024 · 0 comments · Fixed by #15741
Assignees
Labels
type/enhancement Improvements to existing implementation.
Milestone

Comments

@hzxa21
Copy link
Collaborator

hzxa21 commented Feb 21, 2024

We found that "Backfill Snapshot Read Throughput" metric will continuously report 0 for tables that finish backfilling and for table that are already dropped. I think same things apply to other backfill metrics relevant to no-shuffle backfill, arrangement backfill and cdc backfill. It is better to use LabelGuardedMetric here.

Relevant issue: #14838

@hzxa21 hzxa21 added the type/enhancement Improvements to existing implementation. label Feb 21, 2024
@github-actions github-actions bot added this to the release-1.7 milestone Feb 21, 2024
@fuyufjh fuyufjh modified the milestones: release-1.7, release-1.8 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Improvements to existing implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants