Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential sysbench insert perf degradation and barriers pile up #13932

Closed
Tracked by #13945
lmatz opened this issue Dec 12, 2023 · 8 comments
Closed
Tracked by #13945

potential sysbench insert perf degradation and barriers pile up #13932

lmatz opened this issue Dec 12, 2023 · 8 comments
Labels
type/bug Something isn't working type/perf
Milestone

Comments

@lmatz
Copy link
Contributor

lmatz commented Dec 12, 2023

          And the sysbench prepare job failed to check completion in 5 retries with an interval of 60 seconds. So I think there might be insertion performance degradation as well on `nightly-20231211`. Because the prepare finished on time with same configuration when running on `nightly-20231210`

https://buildkite.com/risingwave-test/sysbench/builds/620#018c5aaf-b799-4cd2-9e4e-d2b89cd4b7e0

Originally posted by @cyliu0 in #13931 (comment)

Commit history:
https://github.com/risingwavelabs/rw-commits-history#nightly-20231211

@lmatz lmatz added type/bug Something isn't working type/perf labels Dec 12, 2023
@github-actions github-actions bot added this to the release-1.6 milestone Dec 12, 2023
@lmatz lmatz changed the title potential sysbench insert perf degradation potential sysbench insert perf degradation and barriers pile up Dec 12, 2023
@lmatz
Copy link
Contributor Author

lmatz commented Dec 12, 2023

It looks more like a bug, the duration of insertion and the throughput of insertion between 1210 and 1211 are quite close
And from the commit history, it looks like no PR is directly related to insertion.

@lmatz lmatz mentioned this issue Dec 12, 2023
3 tasks
@cyliu0
Copy link
Collaborator

cyliu0 commented Dec 13, 2023

@cyliu0
Copy link
Collaborator

cyliu0 commented Dec 14, 2023

@chenzl25
Copy link
Contributor

nightly-20231213

I couldn't find this day's Grafana metric data. Or how to keep them from being deleted.

@kwannoel
Copy link
Contributor

nightly-20231213

I couldn't find this day's Grafana metric data. Or how to keep them from being deleted.

https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?from=1702439537779&orgId=1&to=1702517972779&var-component=All&var-datasource=P2453400D1763B4D9&var-instance=benchmark-risingwave&var-namespace=sysbench-daily-test-20231213&var-pod=All&var-table=All

You can adjust the timestamp range, otherwise namespace will not showup.
Screenshot 2023-12-14 at 11 26 34 AM

@cyliu0
Copy link
Collaborator

cyliu0 commented Dec 14, 2023

@chenzl25 We have metrics lost last night. They are investigating the problem.

@chenzl25
Copy link
Contributor

@chenzl25 We have metrics lost last night. They are investigating the problem.

Anyway. We have located the root cause.

@lmatz lmatz closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working type/perf
Projects
None yet
Development

No branches or pull requests

4 participants