Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(sink): json encoder does not preserve microsecond precision #13564

Open
xiangjinwu opened this issue Nov 21, 2023 · 4 comments
Open

bug(sink): json encoder does not preserve microsecond precision #13564

xiangjinwu opened this issue Nov 21, 2023 · 4 comments
Assignees
Labels
component/connector type/bug Something isn't working
Milestone

Comments

@xiangjinwu
Copy link
Contributor

No description provided.

@xuefengze
Copy link
Contributor

It seems that the time type ignores the millisecond part in json encoder?

@xiangjinwu
Copy link
Contributor Author

It seems that the time type ignores the millisecond part in json encoder?

Yes, and we need TimeHandlingMode to fix it without breaking backward compatibility.

@tabVersion
Copy link
Contributor

It seems that the time type ignores the millisecond part in json encoder?

Yes, and we need TimeHandlingMode to fix it without breaking backward compatibility.

Can we resue the same options as the json parser in source?

@xiangjinwu
Copy link
Contributor Author

It seems that the time type ignores the millisecond part in json encoder?

Yes, and we need TimeHandlingMode to fix it without breaking backward compatibility.

Can we resue the same options as the json parser in source?

Yes for the enum definition

#[derive(Clone, Debug)]
pub enum TimeHandling {
Milli,
Micro,
}

Additionally it may need to be exposed as a format option #13109

@xiangjinwu xiangjinwu added component/connector type/bug Something isn't working and removed type/feature labels Nov 30, 2023
@xiangjinwu xiangjinwu self-assigned this Dec 6, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.5, release-1.6 Dec 6, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.7, release-1.8 Mar 6, 2024
@xiangjinwu xiangjinwu modified the milestones: release-1.8, release-1.9 Apr 8, 2024
@xiangjinwu xiangjinwu modified the milestones: release-1.9, release-1.10 May 13, 2024
@xiangjinwu xiangjinwu modified the milestones: release-1.10, release-1.11 Jul 10, 2024
@xiangjinwu xiangjinwu modified the milestones: release-2.1, release-2.2 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/connector type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants