Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: introduce a new metrics for cdc_backfill #13177

Closed
fuyufjh opened this issue Oct 31, 2023 · 0 comments · Fixed by #13777
Closed

Refactor: introduce a new metrics for cdc_backfill #13177

fuyufjh opened this issue Oct 31, 2023 · 0 comments · Fixed by #13777
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Oct 31, 2023

self.metrics
.backfill_snapshot_read_row_count
.with_label_values(&[
upstream_table_id.to_string().as_str(),
self.actor_id.to_string().as_str(),
])
.inc_by(cur_barrier_snapshot_processed_rows);

Currently, the cdc_backfill executor reuses the streaming backfill's metrics. This looks weird. Please introduce a set of new metrics, such as

    pub cdc_backfill_snapshot_read_row_count: GenericCounterVec<AtomicU64>,
    pub cdc_backfill_upstream_output_row_count: GenericCounterVec<AtomicU64>,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants