Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: handle visibility bitmap in StreamChunk::to_protobuf #12460

Closed
st1page opened this issue Sep 20, 2023 · 0 comments · Fixed by #12463
Closed

bug: handle visibility bitmap in StreamChunk::to_protobuf #12460

st1page opened this issue Sep 20, 2023 · 0 comments · Fixed by #12463
Milestone
release-1.3

Comments

@st1page
Copy link
Contributor

st1page commented Sep 20, 2023

Because no bit is defined in PbStreamChunk we can only compact the chunk with the visibility here.
Now the StreamChunk::compact will be called in the StreamChunk::to_protobuf as a workaround.
The ideal final solution might be implement trait Array::to_protobuf(visibility: Bitmap) for each arrays.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-1.3
Development

Successfully merging a pull request may close this issue.

fix(sink): handle visibility in remote sink risingwavelabs/risingwave
1 participant
@st1page