Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics partition_input_bytes for data generator source is not recorded. #12278

Closed
MrCroxx opened this issue Sep 13, 2023 · 3 comments · Fixed by #13284
Closed

Metrics partition_input_bytes for data generator source is not recorded. #12278

MrCroxx opened this issue Sep 13, 2023 · 3 comments · Fixed by #13284
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@MrCroxx
Copy link
Contributor

MrCroxx commented Sep 13, 2023

Describe the bug

When using nexmark source generator, Source Throughput(MB/s) is not shown on Grafana, which queries metrics partition_input_bytes.

image

partition_input_bytes is updated by into_chunk_stream in src/connector/src/source/common.rs, but nexmark source generator doesn't call the function.

@MrCroxx MrCroxx added the type/bug Something isn't working label Sep 13, 2023
@github-actions github-actions bot added this to the release-1.3 milestone Sep 13, 2023
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Sep 13, 2023

The row-level source throughput metrics source_output_row_count(stream_source_output_rows_counts) is held by StreamingMetrics but byte-level source throughput metrics partition_input_count is held by SourceMetrics. Is this by design? @tabVersion

@tabVersion
Copy link
Contributor

The row-level source throughput metrics source_output_row_count(stream_source_output_rows_counts) is held by StreamingMetrics but byte-level source throughput metrics partition_input_count is held by SourceMetrics. Is this by design? @tabVersion

Sorry for late reply. I think no, the metrics are added separately. I will submit a fix.

partition_input_bytes is updated by into_chunk_stream in src/connector/src/source/common.rs, but nexmark source generator doesn't call the function

IIRC, necmark source generates stream chunk directly, shall we use the chunk's size for this metric?

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Nov 7, 2023

IIRC, necmark source generates stream chunk directly, shall we use the chunk's size for this metric?

It's okay for me. But I think it will be better to use the same function for source data gen and normal source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
3 participants