Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking: support for data types in protobuf #10479

Closed
4 of 5 tasks
neverchanje opened this issue Jun 21, 2023 · 2 comments
Closed
4 of 5 tasks

tracking: support for data types in protobuf #10479

neverchanje opened this issue Jun 21, 2023 · 2 comments
Assignees

Comments

@neverchanje
Copy link
Contributor

neverchanje commented Jun 21, 2023

syntax = "proto3";

package alltypes.schema;
option go_package = "alltypes/proto";

import "google/protobuf/timestamp.proto";
import "google/protobuf/duration.proto";
// import "google/protobuf/any.proto";
import "google/protobuf/wrappers.proto";

message AllTypes {
    // standard types
    double double_field = 1;
    float float_field = 2;
    int32 int32_field = 3;
    int64 int64_field = 4;
    uint32 uint32_field = 5;
    uint64 uint64_field = 6;
    sint32 sint32_field = 7;
    sint64 sint64_field = 8;
    fixed32 fixed32_field = 9;
    fixed64 fixed64_field = 10;
    sfixed32 sfixed32_field = 11;
    sfixed64 sfixed64_field = 12;
    bool bool_field = 13;
    string string_field = 14;

    // -- Unsupported
    // bytes bytes_field = 15;
  
    // enum
    enum EnumType {
      DEFAULT = 0;
      OPTION1 = 1;
      OPTION2 = 2;
    }
    EnumType enum_field = 16;
  
    // nested message
    message NestedMessage {
      int32 id = 1;
      string name = 2;
    }
    NestedMessage nested_message_field = 17;
  
    // repeated field
    repeated int32 repeated_int_field = 18;
  
    // oneof field
    oneof example_oneof {
      string oneof_string = 19;
      int32 oneof_int32 = 20;
      EnumType oneof_enum = 21;
    }
  
    // // map field
    // map<string, int32> map_field = 22;
  
    // timestamp
    google.protobuf.Timestamp timestamp_field = 23;
  
    // duration
    google.protobuf.Duration duration_field = 24;
  
    // // any
    // google.protobuf.Any any_field = 25;
  
    // -- Unsupported
    // // struct
    // import "google/protobuf/struct.proto";
    // google.protobuf.Struct struct_field = 26;
  
    // wrapper types
    google.protobuf.Int32Value int32_value_field = 27;
    google.protobuf.StringValue string_value_field = 28;
}
@neverchanje
Copy link
Contributor Author

No longer needed to be tracked in future releases. We can implement map and struct-json conversion on demand.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants