Skip to content

Commit

Permalink
rename AggType::to_protobuf to AggType::to_protobuf_simple
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Chien <[email protected]>
  • Loading branch information
stdrc committed Sep 23, 2024
1 parent 9988c60 commit fbf4f06
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/batch/benches/hash_agg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ fn create_agg_call(
return_type: DataType,
) -> PbAggCall {
PbAggCall {
kind: agg_type.to_protobuf() as i32,
kind: agg_type.to_protobuf_simple() as i32,
args: args
.into_iter()
.map(|col_idx| PbInputRef {
Expand Down
2 changes: 1 addition & 1 deletion src/expr/core/src/aggregate/def.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ impl AggType {
}
}

pub fn to_protobuf(&self) -> PbAggKind {
pub fn to_protobuf_simple(&self) -> PbAggKind {
match self {
Self::Builtin(pb) => *pb,
Self::UserDefined(_) => PbAggKind::UserDefined,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ impl PlanWindowFunction {
DenseRank => PbType::General(PbGeneralType::DenseRank as _),
Lag => PbType::General(PbGeneralType::Lag as _),
Lead => PbType::General(PbGeneralType::Lead as _),
Aggregate(agg_type) => PbType::Aggregate(agg_type.to_protobuf() as _),
Aggregate(agg_type) => PbType::Aggregate(agg_type.to_protobuf_simple() as _),
};

PbWindowFunction {
Expand Down

0 comments on commit fbf4f06

Please sign in to comment.