prune BatchFilter if predicate always true

risingwavelabs · Nov 8, 2024 · e60b4e4 · e60b4e4
1 parent 115e2ef
commit e60b4e4
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/frontend/src/optimizer/rule/batch/batch_iceberg_predicate_pushdown.rs b/src/frontend/src/optimizer/rule/batch/batch_iceberg_predicate_pushdown.rs
@@ -45,13 +45,17 @@ impl Rule for BatchIcebergPredicatePushDownRule {
         assert_eq!(scan.predicate, IcebergPredicate::AlwaysTrue);
 
         let predicate = filter.predicate().clone();
-        let (iceberg_predicate, new_predicate) =
+        let (iceberg_predicate, rw_predicate) =
             rw_predicate_to_iceberg_predicate(predicate, scan.schema().fields());
         let scan = scan.clone_with_predicate(iceberg_predicate);
-        let filter = filter
-            .clone_with_input(scan.into())
-            .clone_with_predicate(new_predicate);
-        Some(filter.into())
+        if rw_predicate.always_true() {
+            Some(scan.into())
+        } else {
+            let filter = filter
+                .clone_with_input(scan.into())
+                .clone_with_predicate(rw_predicate);
+            Some(filter.into())
+        }
     }
 }