Skip to content

Commit

Permalink
fix: don't clean in-memory tracker when clean persist table catalog (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
yezizp2012 authored Dec 4, 2023
1 parent d7d56bd commit c9069c9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
8 changes: 1 addition & 7 deletions src/meta/src/manager/catalog/database.rs
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,7 @@ impl DatabaseManager {
}

pub fn has_in_progress_creation(&self, relation: &RelationKey) -> bool {
self.in_progress_creation_tracker
.contains(&relation.clone())
self.in_progress_creation_tracker.contains(relation)
}

/// For all types of DDL
Expand Down Expand Up @@ -463,11 +462,6 @@ impl DatabaseManager {
self.in_progress_creation_streaming_job.keys().cloned()
}

pub fn clear_creating_stream_jobs(&mut self) {
self.in_progress_creation_tracker.clear();
self.in_progress_creation_streaming_job.clear();
}

pub fn mark_creating_tables(&mut self, tables: &[Table]) {
self.in_progress_creating_tables
.extend(tables.iter().map(|t| (t.id, t.clone())));
Expand Down
1 change: 0 additions & 1 deletion src/meta/src/manager/catalog/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,6 @@ impl CatalogManager {
self.env.event_log_manager_ref().add_event_logs(event_logs);
}

database_core.clear_creating_stream_jobs();
let user_core = &mut core.user;
for table in &tables_to_clean {
// If table type is internal, no need to update the ref count OR
Expand Down

0 comments on commit c9069c9

Please sign in to comment.