fix(object_store): fix sdk error downcast (#16743)

risingwavelabs · May 14, 2024 · c1cc535 · c1cc535
1 parent ff49514
commit c1cc535
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/object_store/src/object/s3.rs b/src/object_store/src/object/s3.rs
@@ -1006,18 +1006,19 @@ where
         } => {
             let sdk_err = inner
                 .as_ref()
-                .downcast_ref::<SdkError<E, aws_smithy_runtime_api::http::Response<SdkBody>>>()
-                .unwrap();
+                .downcast_ref::<SdkError<E, aws_smithy_runtime_api::http::Response<SdkBody>>>();
+
             let err_should_retry = match sdk_err {
-                SdkError::DispatchFailure(e) => {
+                Some(SdkError::DispatchFailure(e)) => {
                     if e.is_timeout() {
                         tracing::warn!(target: "http_timeout_retry", "{e:?} occurs, retry S3 get_object request.");
                         true
                     } else {
                         false
                     }
                 }
-                SdkError::ServiceError(e) => {
+
+                Some(SdkError::ServiceError(e)) => {
                     let retry = match e.err().code() {
                         None => {
                             if config.s3.developer.object_store_retry_unknown_service_error
@@ -1048,7 +1049,7 @@ where
                     retry
                 }
 
-                SdkError::TimeoutError(_err) => true,
+                Some(SdkError::TimeoutError(_err)) => true,
 
                 _ => false,
             };