feat: fix missing column description in row desc for show columns com…

…mand (#13116)
risingwavelabs · Oct 27, 2023 · bc392aa · bc392aa
1 parent ae8f1b6
commit bc392aa
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/e2e_test/ddl/show.slt b/e2e_test/ddl/show.slt
@@ -33,10 +33,10 @@ table description       t3   NULL  volutpat vitae
 query TTT
 show columns from t3;
 ----
-v1 integer false
-v2 integer false
-v3 integer false
-_row_id serial true
+v1 integer false turpis vehicula
+v2 integer false Lorem ipsum dolor sit amet
+v3 integer false NULL
+_row_id serial true consectetur adipiscing elit
 
 statement ok
 create index idx1 on t3 (v1,v2);

diff --git a/e2e_test/extended_mode/basic.slt b/e2e_test/extended_mode/basic.slt
@@ -53,10 +53,10 @@ table description t3        NULL  NULL
 query TTT
 show columns from t3;
 ----
-v1 integer false
-v2 integer false
-v3 integer false
-_row_id serial true
+v1 integer false NULL
+v2 integer false NULL
+v3 integer false NULL
+_row_id serial true NULL
 
 statement ok
 drop table t3;

diff --git a/src/frontend/src/utils/infer_stmt_row_desc.rs b/src/frontend/src/utils/infer_stmt_row_desc.rs
@@ -35,6 +35,11 @@ pub fn infer_show_object(objects: &ShowObject) -> Vec<PgFieldDescriptor> {
                 DataType::Varchar.to_oid(),
                 DataType::Varchar.type_len(),
             ),
+            PgFieldDescriptor::new(
+                "Description".to_owned(),
+                DataType::Varchar.to_oid(),
+                DataType::Varchar.type_len(),
+            ),
         ],
         ShowObject::Connection { .. } => vec![
             PgFieldDescriptor::new(