Skip to content

Commit

Permalink
resolve conflict
Browse files Browse the repository at this point in the history
Signed-off-by: Bugen Zhao <[email protected]>
  • Loading branch information
BugenZhao committed Feb 23, 2024
1 parent a75a1f8 commit ba75e21
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions src/connector/src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ use self::unified::AccessImpl;
use self::upsert_parser::UpsertParser;
use self::util::get_kafka_topic;
use crate::common::AwsAuthProps;
use crate::error::ConnectorResult;
use crate::error::{ConnectorError, ConnectorResult};
use crate::parser::maxwell::MaxwellParser;
use crate::parser::util::{
extract_header_inner_from_meta, extract_headers_from_meta, extreact_timestamp_from_meta,
Expand Down Expand Up @@ -559,7 +559,7 @@ pub trait ByteStreamSourceParser: Send + Debug + Sized + 'static {
}
}

#[try_stream(ok = Vec<SourceMessage>, error = anyhow::Error)]
#[try_stream(ok = Vec<SourceMessage>, error = ConnectorError)]
async fn ensure_largest_at_rate_limit(stream: BoxSourceStream, rate_limit: u32) {
#[for_await]
for batch in stream {
Expand Down
11 changes: 6 additions & 5 deletions src/connector/src/source/iceberg/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use async_trait::async_trait;
use risingwave_common::types::JsonbVal;
use serde::{Deserialize, Serialize};

use crate::error::ConnectorResult;
use crate::parser::ParserConfig;
use crate::source::{
BoxChunkSourceStream, Column, SourceContextRef, SourceEnumeratorContextRef, SourceProperties,
Expand Down Expand Up @@ -71,15 +72,15 @@ impl SplitMetaData for IcebergSplit {
unimplemented!()
}

fn restore_from_json(_value: JsonbVal) -> anyhow::Result<Self> {
fn restore_from_json(_value: JsonbVal) -> ConnectorResult<Self> {
unimplemented!()
}

fn encode_to_json(&self) -> JsonbVal {
unimplemented!()
}

fn update_with_offset(&mut self, _start_offset: String) -> anyhow::Result<()> {
fn update_with_offset(&mut self, _start_offset: String) -> ConnectorResult<()> {
unimplemented!()
}
}
Expand All @@ -95,11 +96,11 @@ impl SplitEnumerator for IcebergSplitEnumerator {
async fn new(
_properties: Self::Properties,
_context: SourceEnumeratorContextRef,
) -> anyhow::Result<Self> {
) -> ConnectorResult<Self> {
Ok(Self {})
}

async fn list_splits(&mut self) -> anyhow::Result<Vec<Self::Split>> {
async fn list_splits(&mut self) -> ConnectorResult<Vec<Self::Split>> {
Ok(vec![])
}
}
Expand All @@ -118,7 +119,7 @@ impl SplitReader for IcebergFileReader {
_parser_config: ParserConfig,
_source_ctx: SourceContextRef,
_columns: Option<Vec<Column>>,
) -> anyhow::Result<Self> {
) -> ConnectorResult<Self> {
unimplemented!()
}

Expand Down

0 comments on commit ba75e21

Please sign in to comment.