overflow

risingwavelabs · Feb 8, 2023 · b92b34d · b92b34d
1 parent c0aa909
commit b92b34d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/e2e_test/batch/functions/pow.slt.part b/e2e_test/batch/functions/pow.slt.part
@@ -43,7 +43,9 @@ select pow(100000, -200000000000000);
 ----
 0
 
-query T
+statement error QueryError: Expr error: Numeric out of range
 select pow(100000, 200000000000000);
-----
-Infinity
+
+
+statement error QueryError: Expr error: Numeric out of range
+select pow(-100000, 200000000000001);
diff --git a/src/expr/src/vector_op/arithmetic_op.rs b/src/expr/src/vector_op/arithmetic_op.rs
@@ -115,7 +115,12 @@ where
     T2: Into<T3> + Debug,
     T3: Pow<T3> + num_traits::Float,
 {
-    Ok(l.into().powf(r.into()))
+    let res = l.into().powf(r.into());
+    if res.is_infinite() {
+        Err(ExprError::NumericOutOfRange)
+    } else {
+        Ok(res)
+    }
 }
 
 #[inline(always)]