Skip to content

Commit

Permalink
feat: deprecate legacy s3 connector (#16337)
Browse files Browse the repository at this point in the history
  • Loading branch information
tabVersion authored Apr 18, 2024
1 parent 3445741 commit b73643a
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 494 deletions.
88 changes: 0 additions & 88 deletions ci/workflows/main-cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -472,72 +472,6 @@ steps:
timeout_in_minutes: 10
retry: *auto-retry

- label: "S3 source check on AWS"
key: "s3-source-check-aws"
command: "ci/scripts/s3-source-test.sh -p ci-release -s run.py"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-s3-source-tests"
|| build.env("CI_STEPS") =~ /(^|,)s3-source-tests?(,|$$)/
depends_on: build
plugins:
- seek-oss/aws-sm#v2.3.1:
env:
S3_SOURCE_TEST_CONF: ci_s3_source_test_aws
- docker-compose#v5.1.0:
run: rw-build-env
config: ci/docker-compose.yml
mount-buildkite-agent: true
environment:
- S3_SOURCE_TEST_CONF
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 20
retry: *auto-retry

- label: "S3 source check on AWS (json parser)"
key: "s3-source-check-aws-json-parser"
command: "ci/scripts/s3-source-test.sh -p ci-release -s json_file.py"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-s3-source-tests"
|| build.env("CI_STEPS") =~ /(^|,)s3-source-tests?(,|$$)/
depends_on: build
plugins:
- seek-oss/aws-sm#v2.3.1:
env:
S3_SOURCE_TEST_CONF: ci_s3_source_test_aws
- docker-compose#v5.1.0:
run: rw-build-env
config: ci/docker-compose.yml
mount-buildkite-agent: true
environment:
- S3_SOURCE_TEST_CONF
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 25
retry: *auto-retry

- label: "S3 source check on AWS (csv parser)"
key: "s3-source-check-aws-csv-parser"
command: "ci/scripts/s3-source-test.sh -p ci-release -s run_csv.py"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-s3-source-tests"
|| build.env("CI_STEPS") =~ /(^|,)s3-source-tests?(,|$$)/
depends_on: build
plugins:
- seek-oss/aws-sm#v2.3.1:
env:
S3_SOURCE_TEST_CONF: ci_s3_source_test_aws
- docker-compose#v5.1.0:
run: rw-build-env
config: ci/docker-compose.yml
mount-buildkite-agent: true
environment:
- S3_SOURCE_TEST_CONF
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 25
retry: *auto-retry

- label: "S3_v2 source check on AWS (json parser)"
key: "s3-v2-source-check-aws-json-parser"
command: "ci/scripts/s3-source-test.sh -p ci-release -s fs_source_v2.py -t json"
Expand Down Expand Up @@ -621,28 +555,6 @@ steps:
timeout_in_minutes: 25
retry: *auto-retry

- label: "S3 source on OpenDAL fs engine"
key: "s3-source-test-for-opendal-fs-engine"
command: "ci/scripts/s3-source-test-for-opendal-fs-engine.sh -p ci-release -s run.py"
if: |
!(build.pull_request.labels includes "ci/main-cron/skip-ci") && build.env("CI_STEPS") == null
|| build.pull_request.labels includes "ci/run-s3-source-tests"
|| build.env("CI_STEPS") =~ /(^|,)s3-source-tests?(,|$$)/
depends_on: build
plugins:
- seek-oss/aws-sm#v2.3.1:
env:
S3_SOURCE_TEST_CONF: ci_s3_source_test_aws
- docker-compose#v5.1.0:
run: rw-build-env
config: ci/docker-compose.yml
mount-buildkite-agent: true
environment:
- S3_SOURCE_TEST_CONF
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 20
retry: *auto-retry

# TODO(Kexiang): Enable this test after we have a GCS_SOURCE_TEST_CONF.
# - label: "GCS source on OpenDAL fs engine"
# key: "s3-source-test-for-opendal-fs-engine"
Expand Down
122 changes: 0 additions & 122 deletions e2e_test/s3/json_file.py

This file was deleted.

128 changes: 0 additions & 128 deletions e2e_test/s3/run.py

This file was deleted.

Loading

0 comments on commit b73643a

Please sign in to comment.