fix(storage): fix duplicated sst_id generated by split_sst function (#…

…18431)
risingwavelabs · Sep 6, 2024 · b00d750 · b00d750
1 parent 5311069
commit b00d750
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/storage/hummock_sdk/src/compaction_group/hummock_version_ext.rs b/src/storage/hummock_sdk/src/compaction_group/hummock_version_ext.rs
@@ -1343,9 +1343,11 @@ pub fn split_sst(
     let mut branch_table_info = sst_info.clone();
     branch_table_info.sst_id = *new_sst_id;
     branch_table_info.sst_size = new_sst_size;
+    *new_sst_id += 1;
 
-    sst_info.sst_id = *new_sst_id + 1;
+    sst_info.sst_id = *new_sst_id;
     sst_info.sst_size = old_sst_size;
+    *new_sst_id += 1;
 
     {
         // related github.com/risingwavelabs/risingwave/pull/17898/
@@ -1364,8 +1366,6 @@ pub fn split_sst(
             .retain(|table_id| !branch_table_info.table_ids.contains(table_id));
     }
 
-    *new_sst_id += 1;
-
     branch_table_info
 }