Skip to content

Commit

Permalink
allow max_dirty_groups_heap_size to be set to 0
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Chien <[email protected]>
  • Loading branch information
stdrc committed Sep 26, 2023
1 parent ba1eaac commit abdbf10
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/stream/src/executor/hash_agg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -650,10 +650,7 @@ impl<K: HashKey, S: StateStore> HashAggExecutor<K, S> {
Message::Chunk(chunk) => {
Self::apply_chunk(&mut this, &mut vars, chunk).await?;

if this.max_dirty_groups_heap_size > 0
&& vars.dirty_groups.estimated_heap_size()
>= this.max_dirty_groups_heap_size
{
if vars.dirty_groups.estimated_heap_size() >= this.max_dirty_groups_heap_size {
// flush dirty groups if heap size is too large, to better prevent from OOM
#[for_await]
for chunk in Self::flush_data(&mut this, &mut vars) {
Expand Down

0 comments on commit abdbf10

Please sign in to comment.