Skip to content

Commit

Permalink
allow range frame calls using range cache policies other than full
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Chien <[email protected]>
  • Loading branch information
stdrc committed Feb 4, 2024
1 parent 1ca5ea4 commit a5b3395
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/stream/src/executor/over_window/general.rs
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,7 @@ impl<S: StateStore> OverWindowExecutor<S> {
.calls
.iter()
.any(|call| call.frame.bounds.is_unbounded());
// TODO(rc): only support full cache for `RANGE` frame for now, for the sake of simplicity
let has_range_frame = args.calls.iter().any(|call| call.frame.bounds.is_range());
let cache_policy = if has_unbounded_frame || has_range_frame {
let cache_policy = if has_unbounded_frame {
// For unbounded frames, we finally need all entries of the partition in the cache,
// so for simplicity we just use full cache policy for these cases.
CachePolicy::Full
Expand Down

0 comments on commit a5b3395

Please sign in to comment.