Skip to content

Commit

Permalink
refine todo comments
Browse files Browse the repository at this point in the history
Signed-off-by: Bugen Zhao <[email protected]>
  • Loading branch information
BugenZhao committed Jun 25, 2024
1 parent b12d23b commit a562042
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/common/src/system_param/local_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ impl LocalSystemParamsManager {
let this = Self::new_inner(initial_params.clone());

// Spawn a task to run the common handler.
// TODO: this may be spawned multiple times under standalone deployment, though idempotent.
// TODO(bugen): this may be spawned multiple times under standalone deployment, though idempotent.
tokio::spawn({
let mut rx = this.tx.subscribe();
async move {
Expand Down
6 changes: 3 additions & 3 deletions src/license/src/manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub enum Tier {
Free,

/// Paid tier.
// TODO: Add more tiers if needed.
// TODO(license): Add more tiers if needed.
Paid,
}

Expand All @@ -55,7 +55,7 @@ pub enum Issuer {
/// The content of a license.
///
/// We use JSON Web Token (JWT) to represent the license. This struct is the payload.
// TODO: Shall we add a version field?
// TODO(license): Shall we add a version field?
#[derive(Debug, Clone, Deserialize)]
#[serde(rename_all = "snake_case")]
pub(super) struct License {
Expand Down Expand Up @@ -139,7 +139,7 @@ impl LicenseManager {
return;
}

// TODO: shall we also validate `nbf`(Not Before)?
// TODO(license): shall we also validate `nbf`(Not Before)?
let mut validation = Validation::new(Algorithm::RS512);
// Only accept `prod` issuer in production, so that we can use license keys issued by
// the `test` issuer in development without leaking them to production.
Expand Down

0 comments on commit a562042

Please sign in to comment.