Merge branch 'main' of ssh://github.com/risingwavelabs/risingwave int…

…o acosd

.cargo/audit.toml

@@ -3,10 +3,7 @@
 # So we ignore known false positives here.
 [advisories]
 ignore = [
-    # We depends on `chrono`, but not `time`, and `chrono` is not affected by `RUSTSEC-2020-0071`
-    # (see https://github.com/time-rs/time/issues/293#issuecomment-946382614).
-    # 
-    # `chrono` also suffers from a similar vulnerability ([`RUSTSEC-2020-0159`](https://rustsec.org/advisories/RUSTSEC-2020-0159),
-    # but it's already patched in `0.4.20` by rewriting vulnerable C function in Rust).
-    "RUSTSEC-2020-0071",
+    # https://github.com/risingwavelabs/risingwave/issues/13703
+    # It's impossible to get rid of OpenSSL (or more accurately, the `rsa` crate), and no patch is yet available.
+    "RUSTSEC-2023-0071",
 ]

.cargo/config.toml

@@ -1,4 +1,8 @@
 # RisingWave cannot compile without SIMD. #7259
+#
+# For some targets, there's an SIMD feature enabled by default.
+# For other targets, we need to enable the feature manually.
+# See `rustc --print=cfg --target=<triple>` for details.
 
 [target.x86_64-unknown-linux-gnu]
 rustflags = ["-Ctarget-feature=+avx2"]
@@ -14,38 +18,17 @@ rustflags = [
 ]
 
 [target.x86_64-apple-darwin]
-rustflags = ["-Ctarget-feature=+avx2"]
+rustflags = [
+    "-Ctarget-feature=+sse4.2",                             # use a generally available feature, since it's not for production
+    "-Clink-arg=-fuse-ld=/usr/local/opt/llvm/bin/ld64.lld",
+]
 
 [target.aarch64-apple-darwin]
 rustflags = [
-    "-Clink-arg=-fuse-ld=/opt/homebrew/opt/llvm/bin/ld64.lld"
+    # neon is enabled by default
+    "-Clink-arg=-fuse-ld=/opt/homebrew/opt/llvm/bin/ld64.lld",
 ]
 
 # Flags for all targets.
 [target.'cfg(all())']
-rustflags = [
-    "--cfg",
-    "tokio_unstable",
-    # uncomment the following two lines to enable `TaskLocalAlloc`
-    # "--cfg",
-    # "enable_task_local_alloc",
-    # lints
-    # TODO: use lint configuration in cargo https://github.com/rust-lang/cargo/issues/5034
-    "-Funused_must_use",
-    "-Aclippy::uninlined_format_args",
-    "-Wclippy::dbg_macro",
-    "-Wclippy::disallowed_methods",
-    "-Wclippy::disallowed_types",
-    "-Wclippy::doc_markdown",
-    "-Wclippy::explicit_into_iter_loop",
-    "-Wclippy::explicit_iter_loop",
-    "-Wclippy::inconsistent_struct_constructor",
-    "-Wclippy::unused_async",
-    "-Wclippy::map_flatten",
-    "-Wclippy::no_effect_underscore_binding",
-    "-Wclippy::await_holding_lock",
-    "-Wrustdoc::broken_intra_doc_links",
-    "-Wfuture_incompatible",
-    "-Wnonstandard_style",
-    "-Wrust_2018_idioms",
-]
+rustflags = ["--cfg", "tokio_unstable"]

.config/hakari.toml

@@ -16,17 +16,30 @@ resolver = "2"
 # https://doc.rust-lang.org/rustc/platform-support.html
 platforms = [
     # "x86_64-unknown-linux-gnu",
+    # "aarch64-unknown-linux-gnu",
     # "x86_64-apple-darwin",
-    # "x86_64-pc-windows-msvc",
+    # "aarch64-apple-darwin",
 ]
 
 # Write out exact versions rather than a semver range. (Defaults to false.)
 # exact-versions = true
 
+unify-target-host = "unify-if-both"
+
 [traversal-excludes]
 workspace-members = [
     "workspace-config",
     "risingwave_object_store",
     "risingwave_bench",
 ]
-third-party = [{ name = "opendal" }, { name = "criterion" }]
+third-party = [
+    { name = "opendal" },
+    # For some reasons, tikv-jemalloc-sys would be compiled twice if being added into `workspace-hack`
+    { name = "tikv-jemalloc-sys", git = "https://github.com/risingwavelabs/jemallocator.git", rev = "64a2d9" },
+    { name = "tikv-jemallocator", git = "https://github.com/risingwavelabs/jemallocator.git", rev = "64a2d9" },
+    # These are solely dev-dependencies. Unifying them may slow down build.
+    { name = "criterion" },
+    { name = "console" },
+    { name = "similar" },
+    { name = "deltalake", git = "https://github.com/risingwavelabs/delta-rs", rev = "5c2dccd4640490202ffe98adbd13b09cef8e007b" },
+]

.config/nextest.toml

@@ -1,5 +1,5 @@
 [profile.default]
-retries = 5
+retries = 0
 slow-timeout = { period = "5s" }
 status-level = "all"
 final-status-level = "slow"
@@ -19,3 +19,22 @@ fail-fast = false
 [profile.ci.junit]
 path = "junit-nextest.xml"
 report-name = "nextest-run"
+
+[test-groups]
+failpoint-limited = { max-threads = 1 }
+
+[[profile.default.overrides]]
+filter = 'test(failpoint_limited::)'
+test-group = 'failpoint-limited'
+
+[[profile.ci.overrides]]
+filter = 'test(failpoint_limited::)'
+test-group = 'failpoint-limited'
+
+[[profile.ci-sim.overrides]]
+filter = 'test(failpoint_limited::)'
+test-group = 'failpoint-limited'
+
+[[profile.ci.junit.overrides]]
+filter = 'test(failpoint_limited::)'
+test-group = 'failpoint-limited'

.dockerignore

@@ -48,3 +48,6 @@ risedev-components.user.env
 riselab-components.user.env
 
 .git/
+
+Dockerfile
+.dockerignore

.git-blame-ignore-revs

@@ -27,3 +27,18 @@ e7b7842826035b645bc4feddf5ef315d0935e35e
 
 # chore: use rustflags for lints (#5508)
 055107da6b969d31cd6aca396f4d9ed209845391
+
+# test: split input/output for planner test (#9902)
+f8266748dcb70541da944664552c1944ff8362e4
+
+# feat(risedev): add check for trailing spaces in `risedev check` (#11294)
+f2a3fd021059e680b35b24c63cff5f8dbe9f9d5f
+
+# chore(rustfmt): format let-chains and let-else #9409
+d70dba827c303373f3220c9733f7c7443e5c2d37
+
+# chore: cargo +nightly fmt (#13162) (format let-chains)
+c583e2c6c054764249acf484438c7bf7197765f4
+
+# chore: replace all ProstXxx with PbXxx (#8621)
+6fd8821f2e053957b183d648bea9c95b6703941f

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -6,15 +6,56 @@ body:
     attributes:
       label: Describe the bug
       description: A clear and concise description of what the bug is.
+  - type: textarea
+    attributes:
+      label: Error message/log
+      description: The error message you see.
+      render: text
   - type: textarea
     attributes:
       label: To Reproduce
-      description: Steps to reproduce the behavior.
+      description: Steps to reproduce the behavior, including the SQLs you run and/or the operations you have done to trigger the bug.
+      placeholder: |
+        First create the tables/sources and materialized views with
+
+        ```sql
+        CREATE TABLE ...
+        CREATE MATERIALIZED VIEW ...
+        ```
+
+        Then the bug is triggered after ...
   - type: textarea
     attributes:
       label: Expected behavior
       description: A clear and concise description of what you expected to happen.
+      placeholder: |
+        I expected to see this happen: *explanation*
+
+        Instead, this happened: *explanation*
+  - type: textarea
+    attributes:
+      label: How did you deploy RisingWave?
+      description: Do you run RisingWave via Docker / Homebrew / RiseDev / RisingWave Cloud / ...?
+      placeholder: |
+        via Docker Compose. My `docker-compose.yml` is: ...
+  - type: textarea
+    attributes:
+      label: The version of RisingWave
+      description: The output of `select version()` and/or the docker image tag and ID.
+      placeholder: |
+        ```
+        dev=> select version();
+                                   version
+        -----------------------------------------------------------------------------
+        PostgreSQL 8.3-RisingWave-0.19.0 (01659936e12307e28e13287dcc3ca899b7f701e3)
+
+
+        docker image ls
+        REPOSITORY                                 TAG         IMAGE ID       CREATED         SIZE
+        risingwavelabs/risingwave                  latest      c0fb5556d7cb   6 days ago      1.99GB
+        ```
   - type: textarea
     attributes:
       label: Additional context
-      description: Add any other context about the problem here.
+      description: Add any other context about the problem here. e.g., the full log files.
+

.github/ISSUE_TEMPLATE/config.yml

@@ -3,5 +3,5 @@ contact_links:
     url: https://github.com/risingwavelabs/risingwave/discussions
     about: Have questions? Welcome to open a discussion.
   - name: Community Chat
-    url: https://join.slack.com/t/risingwave-community/shared_invite/zt-120rft0mr-d8uGk3d~NZiZAQWPnElOfw
+    url: https://risingwave.com/slack
     about: Join the RisingWave Slack community and chat with us.

.github/ISSUE_TEMPLATE/design-rfc.yml

@@ -28,5 +28,5 @@ body:
       label: Q&A
       description: Here's where the doc readers can leave the questions and suggestions
       placeholder: |
-        * Why do you need ...  
+        * Why do you need ...
         * What will happen if ...