Skip to content

Commit

Permalink
fix lint & yaml test
Browse files Browse the repository at this point in the history
Signed-off-by: xxchan <[email protected]>
  • Loading branch information
xxchan committed May 16, 2024
1 parent 4fb91fd commit 9b1056c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions src/connector/src/source/google_pubsub/source/reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@
// See the License for the specific language governing permissions and
// limitations under the License.

use anyhow::Context;
use async_trait::async_trait;
use chrono::{TimeZone, Utc};
use futures_async_stream::try_stream;
use google_cloud_pubsub::subscription::{SeekTo, Subscription};
use google_cloud_pubsub::subscription::Subscription;
use risingwave_common::{bail, ensure};
use tonic::Code;

Expand Down
4 changes: 2 additions & 2 deletions src/connector/with_options_source.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ PubsubProperties:
fields:
- name: pubsub.subscription
field_type: String
comments: 'Pub/Sub subscription to consume messages from. Note that we rely on Pub/Sub to load-balance messages between all Readers pulling from the same subscription. So one `subscription` (i.e., one `Source`) can only used for one MV. Otherwise, different MVs on the same Source will both receive part of the messages. TODO: check and enforce this on Meta.'
comments: 'Pub/Sub subscription to consume messages from. Note that we rely on Pub/Sub to load-balance messages between all Readers pulling from the same subscription. So one `subscription` (i.e., one `Source`) can only used for one MV (shared between the actors of its fragment). Otherwise, different MVs on the same Source will both receive part of the messages. TODO: check and enforce this on Meta.'
required: true
- name: pubsub.emulator_host
field_type: String
Expand All @@ -648,7 +648,7 @@ PubsubProperties:
comments: '`start_snapshot` is a named pub/sub snapshot. If present, the connector will first seek to the snapshot before starting consumption. Snapshots are the preferred seeking mechanism in pub/sub because they guarantee retention of: - All unacknowledged messages at the time of their creation. - All messages created after their creation. Besides retention guarantees, snapshots are also more precise than timestamp-based seeks. See [Seeking to a snapshot](https://cloud.google.com/pubsub/docs/replay-overview#seeking_to_a_timestamp) for more details.'
required: false
- name: pubsub.parallelism
field_type: String
field_type: u32
comments: '`parallelism` is the number of parallel consumers to run for the subscription. TODO: use system parallelism if not set'
required: false
PulsarProperties:
Expand Down

0 comments on commit 9b1056c

Please sign in to comment.