drop queue before await

risingwavelabs · Feb 4, 2024 · 9a0db3f · 9a0db3f
1 parent 2438934
commit 9a0db3f
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/meta/src/barrier/schedule.rs b/src/meta/src/barrier/schedule.rs
@@ -369,12 +369,11 @@ impl ScheduledBarriers {
                 loop {
                     let mut rx = self.inner.changed_tx.subscribe();
                     let mut queue = self.inner.queue.write().await;
-                    if queue.queue.is_empty() {
-                        rx.changed().await.unwrap();
+                    if let Some(scheduled) = queue.queue.pop_front() {
+                        break scheduled
                     } else {
-                        let scheduled = queue.queue.pop_front().expect("non-empty");
-
-                        break scheduled;
+                        drop(queue);
+                        rx.changed().await.unwrap();
                     }
                 }
             } => {