Skip to content

Commit

Permalink
chore(storage): remove Sync requirement on HummockIterator (#16196)
Browse files Browse the repository at this point in the history
  • Loading branch information
wenym1 authored Apr 9, 2024
1 parent a14ff37 commit 98e1c64
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions src/object_store/src/object/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,6 @@ pub struct MonitoredStreamingReader {
streaming_read_timeout: Option<Duration>,
}

unsafe impl Sync for MonitoredStreamingReader {}

impl MonitoredStreamingReader {
pub fn new(
media_type: &'static str,
Expand Down
2 changes: 1 addition & 1 deletion src/storage/src/hummock/iterator/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ pub struct ValueMeta {
/// After creating the iterator instance,
/// - if you want to iterate from the beginning, you need to then call its `rewind` method.
/// - if you want to iterate from some specific position, you need to then call its `seek` method.
pub trait HummockIterator: Send + Sync {
pub trait HummockIterator: Send {
type Direction: HummockIteratorDirection;
/// Moves a valid iterator to the next key.
///
Expand Down

0 comments on commit 98e1c64

Please sign in to comment.