fix backfill tests

risingwavelabs · Oct 9, 2023 · 96c3175 · 96c3175
1 parent de58af7
commit 96c3175
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 18 deletions.
diff --git a/ci/scripts/run-backfill-tests.sh b/ci/scripts/run-backfill-tests.sh
@@ -43,21 +43,13 @@ test_basic() {
 
 test_replication_with_column_pruning() {
    run_sql_file "$PARENT_PATH"/sql/backfill/replication_with_column_pruning/create_base_table.sql
-   run_sql_file "$PARENT_PATH"/sql/backfill/replication_with_column_pruning/insert_seed.sql
-
    # Provide snapshot
-   for i in $(seq 1 18)
-   do
-     run_sql_file "$PARENT_PATH"/sql/backfill/replication_with_column_pruning/insert_recurse.sql
-   done
+   run_sql_file "$PARENT_PATH"/sql/backfill/replication_with_column_pruning/insert.sql
 
    run_sql_file "$PARENT_PATH"/sql/backfill/replication_with_column_pruning/create_mv.sql &
 
    # Provide upstream updates
-   for i in $(seq 1 2)
-   do
-     run_sql_file "$PARENT_PATH"/sql/backfill/replication_with_column_pruning/insert_recurse.sql &
-   done
+   run_sql_file "$PARENT_PATH"/sql/backfill/replication_with_column_pruning/insert.sql &
 
    wait
 
@@ -69,9 +61,9 @@ main() {
   set -euo pipefail
   echo "--- Basic test"
   test_basic
-  # echo "--- Replication with Column pruning"
-  # test_replication_with_column_pruning
-  # echo "Backfill tests complete"
+  echo "--- Replication with Column pruning"
+  test_replication_with_column_pruning
+  echo "Backfill tests complete"
 }
 
 main
diff --git a/ci/scripts/sql/backfill/replication_with_column_pruning/insert.sql b/ci/scripts/sql/backfill/replication_with_column_pruning/insert.sql
@@ -0,0 +1,2 @@
+insert into t1 select generate_series + 1, generate_series + 2, generate_series + 3 from generate_series(1, 1000000);
+flush;
diff --git a/ci/scripts/sql/backfill/replication_with_column_pruning/insert_recurse.sql b/ci/scripts/sql/backfill/replication_with_column_pruning/insert_recurse.sql
diff --git a/ci/scripts/sql/backfill/replication_with_column_pruning/insert_seed.sql b/ci/scripts/sql/backfill/replication_with_column_pruning/insert_seed.sql
diff --git a/src/stream/src/executor/backfill/utils.rs b/src/stream/src/executor/backfill/utils.rs
@@ -533,7 +533,7 @@ pub(crate) async fn persist_state_per_vnode<S: StateStore, const IS_REPLICATED:
             {
                 continue;
             } else {
-                assert_eq!(old_state[0] == Some((*vnode).to_scalar().into()));
+                assert_eq!(old_state[0], Some((*vnode).to_scalar().into()));
                 assert_eq!(old_state.len(), temporary_state.len());
                 // There's some progress, update the state.
                 table.write_record(Record::Update {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		insert into t1 select generate_series + 1, generate_series + 2, generate_series + 3 from generate_series(1, 1000000);
		flush;