add test

risingwavelabs · Aug 5, 2024 · 9474aa1 · 9474aa1
1 parent 462275f
commit 9474aa1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/ci/scripts/deterministic-recovery-test.sh b/ci/scripts/deterministic-recovery-test.sh
@@ -9,7 +9,7 @@ echo "--- Download artifacts"
 download-and-decompress-artifact risingwave_simulation .
 chmod +x ./risingwave_simulation
 
-export RUST_LOG="risingwave_meta::barrier::recovery=debug,\
+export RUST_LOG="info,risingwave_meta::barrier::recovery=debug,\
 risingwave_meta::manager::catalog=debug,\
 risingwave_meta::rpc::ddl_controller=debug,\
 risingwave_meta::barrier::mod=debug,\

diff --git a/src/meta/src/barrier/recovery.rs b/src/meta/src/barrier/recovery.rs
@@ -77,9 +77,15 @@ impl GlobalBarrierManagerContext {
 
                 // Clean dirty fragments.
                 let stream_job_ids = mgr.catalog_manager.list_stream_job_ids().await?;
+                let stream_job_ids = &stream_job_ids;
+                let mut all_table_fragments = Vec::<u32>::new();
+                // let ptr = ((&mut all_table_fragments) as *mut Vec<u32>) as usize;
                 let to_drop_table_fragments = mgr
                     .fragment_manager
                     .list_dirty_table_fragments(|tf| {
+                        // // SAFETY: trust me
+                        // let all_table_fragments: &mut Vec<_> = unsafe { &mut *(ptr as *mut Vec<u32>) };
+                        all_table_fragments.push(tf.table_id().table_id);
                         !stream_job_ids.contains(&tf.table_id().table_id)
                     })
                     .await;
@@ -89,7 +95,9 @@ impl GlobalBarrierManagerContext {
                     .collect();
                 debug!(
                     ?stream_job_ids,
-                    "clean dirty table fragments: {:?}", to_drop_streaming_ids
+                    ?all_table_fragments,
+                    "clean dirty table fragments: {:?}",
+                    to_drop_streaming_ids
                 );
 
                 let _unregister_table_ids = mgr

diff --git a/src/meta/src/manager/catalog/fragment.rs b/src/meta/src/manager/catalog/fragment.rs
@@ -221,7 +221,7 @@ impl FragmentManager {
 
     pub async fn list_dirty_table_fragments(
         &self,
-        check_dirty: impl Fn(&TableFragments) -> bool,
+        mut check_dirty: impl FnMut(&TableFragments) -> bool,
     ) -> Vec<TableFragments> {
         self.core
             .read()