update java checkstyle

risingwavelabs · Jan 12, 2024 · 90db6af · 90db6af
1 parent cdb0c91
commit 90db6af
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/java/tools/maven/checkstyle.xml b/java/tools/maven/checkstyle.xml
@@ -191,10 +191,24 @@ This file is based on the checkstyle file of Apache Beam.
             <property name="illegalPkgs" value="io.netty"/>
             <message key="import.illegal" value="{0}; Use flink-shaded-netty instead."/>
         </module>
+        <!--
         <module name="IllegalImport">
             <property name="illegalPkgs" value="com.google.common"/>
             <message key="import.illegal" value="{0}; Use flink-shaded-guava instead."/>
         </module>
+        -->
+        <module name="IllegalImport">
+            <property name="illegalClasses" value="java.util.Date, java.sql.Date, java.sql.Timestamp, java.sql.Time"/>
+            <message key="import.illegal" value="{0}; Use java.time.* instead."/>
+        </module>
+        <module name="IllegalImport">
+            <property name="illegalClasses" value="java.text.DateFormat, java.text.SimpleDateFormat"/>
+            <message key="import.illegal" value="{0}; Use java.time.* instead."/>
+        </module>
+        <module name="IllegalImport">
+            <property name="illegalClasses" value="java.util.Calendar, java.util.GregorianCalendar"/>
+            <message key="import.illegal" value="{0}; Use java.time.* instead."/>
+        </module>
 
         <module name="RedundantModifier">
             <!-- Checks for redundant modifiers on various symbol definitions.

diff --git a/java/tools/maven/suppressions.xml b/java/tools/maven/suppressions.xml
@@ -30,5 +30,4 @@ under the License.
 
     <suppress files=".*" checks="javadoc"/>
     <suppress files=".*" checks="AvoidStarImport"/>
-    <suppress files=".*" checks="IllegalImport"/>
-</suppressions>
+</suppressions>